Add Dataplane Status gRPC message #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sergeymatov
commented
Jul 24, 2025
sergeymatov
commented
- Interfaces status basic info
- FRR status and applied config info
- Dataplane generic info
sergeymatov
force-pushed
the
pr/smatov/dataplane-status
branch
from
9049319 to
504b82c
Compare
sergeymatov
force-pushed
the
pr/smatov/dataplane-status
branch
2 times, most recently
from
ce4ff69 to
8573e94
Compare
Frostman
requested changes
Jul 28, 2025
sergeymatov
force-pushed
the
pr/smatov/dataplane-status
branch
2 times, most recently
from
94f0a9c to
ec07e12
Compare
sergeymatov
force-pushed
the
pr/smatov/dataplane-status
branch
7 times, most recently
from
f793bdf to
e7642c5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces comprehensive dataplane status reporting capabilities to the gRPC API, adding a new GetDataplaneStatus service method that provides monitoring and diagnostic information about the gateway's operational state.
- Adds a new gRPC service method
GetDataplaneStatuswith request/response messages - Introduces status enums for interface states, FRR components, and overall dataplane health
- Implements comprehensive test coverage using Bolero fuzzing framework
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| proto/dataplane.proto | Defines new status enums and gRPC messages for dataplane status reporting |
| pkg/dataplane/dataplane.pb.go | Generated Go bindings for the new status types and messages |
| pkg/dataplane/dataplane_grpc.pb.go | Generated Go gRPC service bindings for GetDataplaneStatus method |
| src/lib.rs | Exports new status types and request/response messages |
| src/bolero/status.rs | Implements comprehensive fuzzing test generators for all status types |
| src/bolero/mod.rs | Registers the new status module |
| tests/simple_test.rs | Adds test implementation for the new gRPC service method |
| Cargo.toml | Version bump from 0.12.1 to 0.13.0 |
mvachhar
previously approved these changes
Aug 18, 2025
Contributor
mvachhar
left a comment
mvachhar
left a comment
There was a problem hiding this comment.
This is a good start, but based on what we've seen so far, we're going to need status to get the light status on optics, configuration of the NIC, etc. Everything we need to debug basic L1/L2 connectivity to the switching tier.
sergeymatov
force-pushed
the
pr/smatov/dataplane-status
branch
4 times, most recently
from
b2aae88 to
8d2c7b1
Compare
Frostman
requested changes
Oct 1, 2025
Member
Frostman
left a comment
Frostman
left a comment
There was a problem hiding this comment.
Looks ok overall, few small comments
sergeymatov
force-pushed
the
pr/smatov/dataplane-status
branch
from
8d2c7b1 to
09285e4
Compare
sergeymatov
force-pushed
the
pr/smatov/dataplane-status
branch
4 times, most recently
from
98bd283 to
802dec5
Compare
Frostman
requested changes
Oct 9, 2025
sergeymatov
force-pushed
the
pr/smatov/dataplane-status
branch
2 times, most recently
from
9b819c5 to
b260979
Compare
Frostman
reviewed
Oct 9, 2025
sergeymatov
force-pushed
the
pr/smatov/dataplane-status
branch
from
b260979 to
58cf757
Compare
sergeymatov
force-pushed
the
pr/smatov/dataplane-status
branch
from
58cf757 to
04aa9ac
Compare
Signed-off-by: Sergey Matov <[email protected]>
Signed-off-by: Sergey Matov <[email protected]>
FrrStatus is not consist of Zebra status and FrrAgent status. Number of applied configs and failed configs for Frr also included. Signed-off-by: Sergey Matov <[email protected]>
Signed-off-by: Sergey Matov <[email protected]>
Added dataplane status message, don't breaks existing API. Signed-off-by: Sergey Matov <[email protected]>
sergeymatov
force-pushed
the
pr/smatov/dataplane-status
branch
from
04aa9ac to
0415e9c
Compare
Frostman
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.