Skip to content
This repository has been archived by the owner on Aug 13, 2020. It is now read-only.

remove screenshot from publisher dashboard #1044

Merged
merged 2 commits into from
Jan 22, 2020
Merged

remove screenshot from publisher dashboard #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e7b402
add in new metabase dashboard
andrewmcodes Jan 21, 2020
be0504c
revert previous changes and remove screenshot from publisher dashboard
andrewmcodes Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/publisher_dashboards_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ class PublisherDashboardsController < ApplicationController
before_action :authenticate_user!

def show
@properties = current_user.properties.active.includes(:screenshot_attachment).order("status, name")
@properties = current_user.properties.active.order("status, name")
end
end
4 changes: 0 additions & 4 deletions app/views/properties/_overview_card.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,9 @@
</div>
<% end %>
<% end %>
<figure class="embed-responsive embed-responsive-4by3 mb-0">
<%= link_to image_tag(property.screenshot.attached? ? property.screenshot : "missing-screenshot.jpg", class: "embed-responsive-item"), property %>
</figure>
<%= card_body padding: "p-0" do %>
<%= render_later async_property_card_footer_path(property_id: property.id) do %>
<i class="fa fa-spinner fa-spin text-center d-block"></i>
<% end %>
<% end %>

<% end %>