Replace ForgeIdentifier with string type #5475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
rust
krlvi
reviewed
Nov 6, 2024
| /// None if is no review unit, eg. no Pull Request has been created. | ||
| #[serde(default)] | ||
| pub forge_id: Option<ForgeIdentifier>, | ||
| pub pull_request_id: Option<i32>, |
Member
There was a problem hiding this comment.
Perhaps update the docs above - is it a PR number or a PR id? The previous type had PR number. The GitHub api has both... and i always mix them up. I think the PR number needs a repo as well, while the PR ID is more globally unique or something.
Also - you probably want useize not i32
krlvi
previously approved these changes
Nov 6, 2024
mtsgrd
force-pushed
the
remove-forge-id-type
branch
from
76d4313 to
9e22c6f
Compare
krlvi
approved these changes
Nov 6, 2024
Member
krlvi
left a comment
krlvi
left a comment
There was a problem hiding this comment.
nvm. i initially though about deserializing the value from the old type to the new type but just realised that since the name is different it wont be a problem.
i should get some sleep
- simplifying to keep things simple in the front end
mtsgrd
force-pushed
the
remove-forge-id-type
branch
from
9e22c6f to
b635d94
Compare
mtsgrd
force-pushed
the
remove-forge-id-type
branch
from
b635d94 to
54caba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifying to keep things simple in the front end
This is part of a stack made with GitButler: