Skip to content

Conversation

@Byron
Copy link
Collaborator

@Byron Byron commented Aug 28, 2024

Fixes #4778.

Tasks

  • enable CURL for HTTPS support
  • Validate HTTPS is working

Notes for the Reviewer

As this now pulls in more C-dependencies, compilation might be more prone to failure, particularly on Windows.
It's probably good to make a test-release to validate it works.

@vercel
Copy link

vercel bot commented Aug 28, 2024

@Byron is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the rust Pull requests that update Rust code label Aug 28, 2024
@Byron Byron marked this pull request as ready for review August 28, 2024 10:58
@Byron Byron requested a review from krlvi August 28, 2024 10:59
@krlvi
Copy link
Member

krlvi commented Aug 28, 2024

we can test this out with a nightly build

@krlvi krlvi merged commit b2cdc37 into gitbutlerapp:master Aug 28, 2024
@Byron Byron deleted the fix-clone branch August 28, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clone a repository not work: 'https' is not compiled in

2 participants