better rev-walk in branch listing #4744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
12 tasks
It's a bit more intuitive than `id().ancestors()` when coming from `git2`.
Byron
commented
Aug 23, 2024
|
|
||
| type OidFilter = dyn Fn(&git2::Commit) -> Result<bool>; | ||
|
|
||
| /// Generally, all traversals will use no particular ordering, it's implementation defined in `git2`. |
There was a problem hiding this comment.
I looked into replacing l with gitoxide, but only ended up documenting this type as I though it's not really worth replacing something this trivial as it would need to on-demand open a gix::Repository again.
Once merge_base is also available, I think I might change the CommandContext to also open a gix::Repository lazily.
krlvi
approved these changes
Aug 23, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #4670
Tasks
git2