Follow-up cleanup of Branch-Listing with gix
#4652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
They are supported when the respective bstring feature is used.
This is a change in perception, as `given_name()` was the name of a virtual-branch, which is also used to correlate other similarly named branches. Thus, it's now more than just that, and for lack of a better word it's called the 'identity' of a branch. It's something very specific and shouldn't accidentally be used wrongly, hence the strong typing.
krlvi
approved these changes
Aug 9, 2024
krlvi
added a commit
that referenced
this pull request
Aug 9, 2024
Revert "Merge pull request #4652 from gitbutlerapp/git2-to-gix"
Byron
added a commit
to Byron/gitbutler
that referenced
this pull request
Aug 9, 2024
…p/git2-to-gix"" This reverts commit 88496e6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of TODOs were left in #4642 which were left only to keep the original PR slim.
The planned changes might go further in the codebase and touch many files, but let's hope the type-changes are more contained for now.
Now it's time to remove them and work towards a more type-safe future.
Tasks
gixon GitHub when merged