Remove custom-commands ACL boilerplate - #13975
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes now-unneeded Tauri ACL workaround plumbing after the project’s Tauri dependency includes the upstream remote-origin ACL fix.
Changes:
- Deletes the hand-maintained custom command permission manifest.
- Removes the
allow-custom-commandscapability entry. - Reverts the Tauri build script to plain
tauri_build::build().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/gitbutler-tauri/permissions/default.toml |
Removes the custom permission list for all application commands. |
crates/gitbutler-tauri/capabilities/main.json |
Drops the deleted allow-custom-commands permission reference. |
crates/gitbutler-tauri/build.rs |
Removes explicit AppManifest build setup and uses default Tauri build behavior. |
tauri 2.11.1 includes tauri-apps/tauri#15266, which enforces ACL for non-local origins even when no AppManifest is configured. The hand-rolled `allow-custom-commands` permission existed solely to flip `has_app_acl_manifest` so custom command invocations from local origins would not bypass the ACL gate (and, by side effect, also be checked for remote origins). With the upstream fix in place, remote origins are checked regardless, and local origins remain permissive without an AppManifest. The capability declares `local: true`, so the workaround is no longer load-bearing. Drop `permissions/default.toml`, the `allow-custom-commands` entry from `capabilities/main.json`, and the explicit `try_build(... AppManifest ...)` plumbing in `build.rs` -- back to plain `tauri_build::build()`.
mtsgrd
force-pushed
the
remove-custom-commands-acl
branch
from
May 28, 2026 12:00
9ff9992 to
c1f7d1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tauri 2.11.1 includes tauri-apps/tauri#15266, which enforces ACL for
non-local origins even when no AppManifest is configured. The hand-rolled
allow-custom-commandspermission existed solely to fliphas_app_acl_manifestso custom command invocations from local originswould not bypass the ACL gate (and, by side effect, also be checked for
remote origins).
With the upstream fix in place, remote origins are checked regardless,
and local origins remain permissive without an AppManifest. The
capability declares
local: true, so the workaround is no longerload-bearing.
Drop
permissions/default.toml, theallow-custom-commandsentry fromcapabilities/main.json, and the explicittry_build(... AppManifest ...)plumbing in
build.rs-- back to plaintauri_build::build().