refactor(tui): move DebugAsType into its own module - #13062
Merged
Conversation
github-actions
Bot
added
rust
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the legacy status TUI code by extracting the DebugAsType wrapper into a shared utils module, removing the previous local DebugType helper and updating call sites accordingly.
Changes:
- Added
utils::DebugAsTypeas a reusable wrapper with a type-name-basedDebugimplementation. - Replaced
DebugTypeusages in the legacy status TUI withDebugAsType. - Removed the inline
DebugTypedefinition from the TUI module.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/but/src/utils/mod.rs | Registers and re-exports the new debug_as_type utility module. |
| crates/but/src/utils/debug_as_type.rs | Introduces the extracted DebugAsType wrapper type and trait impls. |
| crates/but/src/command/legacy/status/tui/mod.rs | Switches TUI message wrapper from DebugType to DebugAsType and removes the old local helper. |
| crates/but/src/command/legacy/status/tui/details.rs | Updates imports and struct fields to use DebugAsType instead of DebugType. |
davidpdrsn
force-pushed
the
dp-tui-view-diff
branch
from
March 27, 2026 14:12
d4b5790 to
541ace8
Compare
davidpdrsn
force-pushed
the
dp-move-debug-as-type
branch
from
March 27, 2026 14:12
b47fa3a to
cae5bbd
Compare
davidpdrsn
force-pushed
the
dp-tui-view-diff
branch
from
March 27, 2026 15:48
8bef897 to
614dff2
Compare
davidpdrsn
force-pushed
the
dp-move-debug-as-type
branch
from
March 27, 2026 15:48
cae5bbd to
d6cea77
Compare
davidpdrsn
force-pushed
the
dp-tui-view-diff
branch
from
March 27, 2026 16:19
614dff2 to
08d6968
Compare
davidpdrsn
requested review from
Byron,
Caleb-T-Owens,
estib-vega,
krlvi,
mtsgrd,
schacon and
slarse
as code owners
March 27, 2026 16:19
davidpdrsn
force-pushed
the
dp-move-debug-as-type
branch
from
March 27, 2026 16:25
d6cea77 to
d5e456b
Compare
davidpdrsn
force-pushed
the
dp-move-debug-as-type
branch
from
March 27, 2026 17:03
d5e456b to
b928107
Compare
davidpdrsn
removed request for
Byron,
Caleb-T-Owens,
estib-vega,
krlvi,
mtsgrd,
schacon and
slarse
March 27, 2026 17:04
davidpdrsn
enabled auto-merge
March 27, 2026 17:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 4 of 4 in a stack made with GitButler:
Modeand related types into their own module #13063DebugAsTypeinto its own module #13062 👈