[WIP] Extend support for reporting of build platform #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed __i586__ and __i686__ from checks for the x86 target platform, as they indicate specific processor versions... __i386__ (and/or __x86__?) should always be set in that case. Signed-off-by: Adric Norris <[email protected]>
Extend support for detection and reporting of build platform, via the `git version --build-options' command, to non x86/x86_64 targets. The list of GCC target defines used to flesh out the identification came from <https://sourceforge.net/p/predef/wiki/Architectures/>. Signed-off-by: Adric Norris <[email protected]>
landstander668
changed the title
|
@landstander668 any updates? |
|
Apologies, but I haven't really been able to work on this recently, and it doesn't look like this is going to change in the near future. I'm closing the PR for now... will open a new one if/when I have an opportunity to properly revisit the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dscho This is a continuation of the work from PR #866, to hopefully make it easier for you to get the changes merged upstream. The first commit is a very small cleanup to what you've already merged, since I misunderstood the purpose of some of the platform defines. The second extends support to all other platforms which I was able to identify, based upon the information from here.