[bugfix] fix wsl mode bits error in subdir #4660
Conversation
|
Please ignore the 2 ci errors, it seems they are not related with the modified code |
| memcpy(buf + off, fse->dirent.d_name, fse->len); | ||
| buf[off + fse->len] = '\0'; | ||
| if (xutftowcs_long_path(wpath, buf) >= 0) | ||
| copy_wsl_mode_bits_from_disk(wpath, -1, &fse->st_mode); |
There was a problem hiding this comment.
fix wsl mode bits bug in subdir
Support for wsl mode bits was previously added to git,
but there was a bug because the filenames provided by
fscache did not contain paths.This commit fixes the issue.
I am sorry, but this commit message does nothing at all to help me to understand while the previous fdata->FileName would not be enough.
Please review https://github.blog/2022-06-30-write-better-commits-build-better-projects/ and improve the commit message accordingly.
There was a problem hiding this comment.
sorry, now commit updated.
Ex: fdata->FileName is only foo.sh while we need path/to/foo.sh to open the file.
|
I don't know why no progress in months, I have just rebased and pushed again, if there is something should be fixed, please let me know. |
fix wsl mode bits bug in subdir Support for wsl mode bits was previously added to git, but there was a bug because the filenames provided by fdata did not contain paths. Ex: fdata->FileName is only foo.sh while we need path/to/foo.sh to open the file. This commit fixes the issue. Signed-off-by: lixungeng <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
Various reasons, among others that I had briefly lost support to work on this as part of my day job, but things are back on track! |
|
/add relnote bug The support code enabled via The workflow run was started |
The support code enabled via `core.WSLCompat` did not work well with files stored in subdirectories of the worktree, which [has been fixed](git-for-windows/git#4660). Signed-off-by: gitforwindowshelper[bot] <[email protected]>
Support for wsl mode bits was previously added to git, but there was a bug because the filenames provided by fscache did not contain paths.
This commit fixes the issue.
The previous feature is added in PR #4438,
but at that time I didn't tested so much.
Sorry to have this bug.
To test this feature, set core.wslcompat to ture and core.filemode to true and make sure repo is on NTFS.