Make sure errno is set when socket operations fail
#2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffhostetler I did not test this, like, at all. Could I ask you...? You seemed to have a concrete scenario where this was an issue, maybe you can cherry-pick and see whether this PR would fix it? |
dscho
force-pushed
the
mingw-setsockopt
branch
from
2139350 to
077656c
Compare
|
Sure. I'll look at it tomorrow as I'm testing what I'm working on now. I wasn't sure if we wanted this in GFW or initially send it upstream. |
Great, thanks!
I'd like to test it in Git for Windows for a while first, then send it upstream. |
|
@jeffhostetler ping? |
|
yeah. i got distracted.... sorry. |
|
Should we include bind() and listen() too ? |
|
https://github.com/jeffhostetler/git/tree/mingw-setsockopt I gave it a try on top of the stuff I'm currently working on and it seemed ok, I tweaked the WINSOCK_RETURN() macro a bit to make it easier to debug in GDB. |
How? |
|
See my branch. I didn't modify your branch. I left in the fprintf's where I was testing it interactively. |
Could you kindly point me to it? I lost track... |
Oy, I had to scroll back only 3 lines to see it. Sorry for the noise. |
dscho
force-pushed
the
mingw-setsockopt
branch
from
077656c to
879ba71
Compare
And @jeffhostetler could you have another look over the patch? |
dscho
force-pushed
the
mingw-setsockopt
branch
from
879ba71 to
234baba
Compare
Closed
|
I just pushed another fixup to my branch and kicked off #2417 to let the CI tests run. |
The winsock2 library provides functions that work on different data types than file descriptors, therefore we wrap them. But that is not the only difference: they also do not set `errno` but expect the callers to enquire about errors via `WSAGetLastError()`. Let's translate that into appropriate `errno` values whenever the socket operations fail so that Git's code base does not have to change its expectations. This closes git-for-windows#2404 Helped-by: Jeff Hostetler <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
mingw-setsockopt
branch
from
234baba to
c11f75c
Compare
jeffhostetler
approved these changes
Nov 25, 2019
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2019
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2019
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2019
Make sure `errno` is set when socket operations fail
dscho
added a commit
that referenced
this pull request
Nov 26, 2019
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 27, 2019
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 17, 2024
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 19, 2024
Make sure `errno` is set when socket operations fail
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 30, 2024
Make sure `errno` is set when socket operations fail
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 30, 2024
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 31, 2024
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 31, 2024
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 1, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 1, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 1, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 1, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 1, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 2, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 2, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 2, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 3, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 6, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 6, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 7, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 7, 2025
Make sure `errno` is set when socket operations fail
Merged
dscho
added a commit
to dscho/git
that referenced
this pull request
Jan 7, 2025
Make sure `errno` is set when socket operations fail
dscho
added a commit
to dscho/git
that referenced
this pull request
Jan 7, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 7, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 7, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 8, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 8, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 8, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 8, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 9, 2025
Make sure `errno` is set when socket operations fail
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 9, 2025
Make sure `errno` is set when socket operations fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
mingw_*()function family that works with sockets failed to seterrno, as noticed in #2404.