Git commands inside vscode fail when using basic authentication

[isaacag]

• I was not able to find an open or closed issue matching what I'm seeing

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

$ git --version --build-options

git version 2.46.0.windows.1
cpu: x86_64
built from commit: 2e6a859ffc0471f60f79c1256f766042b0d5d17d
sizeof-long: 4
sizeof-size_t: 8
shell-path: D:/git-sdk-64-build-installers/usr/bin/sh
feature: fsmonitor--daemon
libcurl: 8.9.0
OpenSSL: OpenSSL 3.2.2 4 Jun 2024
zlib: 1.3.1

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

$ cmd.exe /c ver

Microsoft Windows [Version 10.0.19045.4651]

• What options did you set as part of the installation? Or did you choose the
  defaults?

# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
> type "$env:USERPROFILE\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Editor Option: Nano
Custom Editor Path: 
Default Branch Option:
Path Option: Cmd
SSH Option: OpenSSH
Tortoise Option: false
CURL Option: OpenSSL
CRLF Option: CRLFAlways
Bash Terminal Option: MinTTY
Git Pull Behavior Option: Merge
Use Credential Manager: Enabled
Performance Tweaks FSCache: Enabled
Enable Symlinks: Disabled
Enable Pseudo Console Support: Disabled
Enable FSMonitor: Disabled

• Any other interesting things about your environment that might be related
  to the issue you're seeing?

No

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Powershell (but also tested in CMD and Git Bash)

• What commands did you run to trigger this issue? If you can provide a
  Minimal, Complete, and Verifiable example
  this will help us understand the issue.

git config --system --unset credential.helper
git pull

• What did you expect to occur after running these commands?

1. Open a terminal inside Visual Studio Code
2. Run git commands above

At 2 after two vscode popups for user and password git command is executed.

• What actually happened instead?

At 2 after two vscode popups for user and password, terminal shows:
fatal: read error: Invalid argument
fatal: expected flush after ref listing

• If the problem was occurring with a specific repository, can you provide the
  URL to that repository to help us with testing?

Problem is happening in all repositories.

• Notes

Downgrading to Git 2.45 fixes the problem.
Error is not reproducible on terminals outside vscode (powershell, cmd, git bash).
Error is not reproducible when windows credential manager integration is active.

[dscho]

I can reproduce this problem. A less invasive reproducer is:

$ git -c credential.helper= -c credential.helper= ls-remote https://github.com/<private-repository>

Unfortunately, due to the way VS Code inserts itself via GIT_ASKPASS, the private repository must exist and the current user needs to be authorized to access it, therefore it is not such a straight-forward reproducer.

[dscho]

I've bisected this to git-for-windows/msys2-runtime@a4d92d6.

@tyan0 this is one of your patches (backported from your upstream commit cygwin/cygwin@55431b4), do you have any idea what is going wrong here?

[tyan0]

I could reproduce the problem. I'll look into this problem, so please wait a while.

[dscho]

I could reproduce the problem. I'll look into this problem, so please wait a while.

Thank you.

[tyan0]

@dscho I have submitted a patch for this issue: https://cygwin.com/pipermail/cygwin-patches/2024q3/012747.html.
For cygwin-3_5-branch, please try cygwin-3_5-branch.patch

[dscho]

/add relnote bug When using an askpass helper (e.g. implicitly when running inside VS Code's internal terminal), Git v2.46.0 would error out with "read error: Invalid argument"; This bug has been fixed.

The workflow run was started