mingw: when running in a Windows container, try to rename() harder

It is a known issue that a rename() can fail with an "Access denied" error at times, when copying followed by deleting the original file works. Let's just fall back to that behavior. Signed-off-by: JiSeop Moon <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows · Dec 17, 2024 · 1e220c0 · 1e220c0
1 parent 1c10ce3
commit 1e220c0
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/compat/mingw.c b/compat/mingw.c
@@ -2738,6 +2738,13 @@ int mingw_rename(const char *pold, const char *pnew)
 		gle = GetLastError();
 	}
 
+	if (gle == ERROR_ACCESS_DENIED && is_inside_windows_container()) {
+		/* Fall back to copy to destination & remove source */
+		if (CopyFileW(wpold, wpnew, FALSE) && !mingw_unlink(pold))
+			return 0;
+		gle = GetLastError();
+	}
+
 	/* revert file attributes on failure */
 	if (attrs != INVALID_FILE_ATTRIBUTES)
 		SetFileAttributesW(wpnew, attrs);