mingw: suggest windows.appendAtomically in more cases

When running Git for Windows on a remote APFS filesystem, it would appear that the `mingw_open_append()`/`write()` combination would fail almost exactly like on some CIFS-mounted shares as had been reported in #2753, albeit with a different `errno` value. Let's handle that `errno` value just the same, by suggesting to set `windows.appendAtomically=false`. Signed-off-by: David Lomas <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows · Jan 28, 2025 · 0453ca8 · 0453ca8
1 parent a4a8b02
commit 0453ca8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/compat/mingw.c b/compat/mingw.c
@@ -787,7 +787,7 @@ ssize_t mingw_write(int fd, const void *buf, size_t len)
 {
 	ssize_t result = write(fd, buf, len);
 
-	if (result < 0 && (errno == EINVAL || errno == ENOSPC) && buf) {
+	if (result < 0 && (errno == EINVAL || errno == EBADF || errno == ENOSPC) && buf) {
 		int orig = errno;
 
 		/* check if fd is a pipe */
@@ -813,7 +813,7 @@ ssize_t mingw_write(int fd, const void *buf, size_t len)
 			}
 
 			errno = orig;
-		} else if (orig == EINVAL)
+		} else if (orig == EINVAL || errno == EBADF)
 			errno = EPIPE;
 		else {
 			DWORD buf_size;