git-artifacts: a couple of minor fixes #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Schindelin <[email protected]>
The linter has a hard time recognizing `core.setOutput()`. However, every `github-script` step has a naturally-defined output: `result`, set to the return value of the script. Let's use that instead. Signed-off-by: Johannes Schindelin <[email protected]>
The name given to a particular workflow run is shown in the overview of workflow runs in GitHub's UI, and are therefore a really good spot to surface information that is relevant to the reader. For example, if a `git-artifacts` workflow run was started with only a subset of the artifacts to build, let's state that in the workflow run's name, as it is vital information. Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
When building from a tag, the version in mingw-w64-git's `PKGBUILD` will be changed as part of the build. We already had code intending to publish that change, but we forgot to commit it before building a Git bundle, which does not work... Signed-off-by: Johannes Schindelin <[email protected]>
We currently use a bogus `PACKAGER` information that is derived from the
`${{ github.actor }}`, which is the GitForWindowsHelper GitHub App.
Since we're already using my personal GPG key to sign those packages,
might just as well use my name as the packager, too.
Signed-off-by: Johannes Schindelin <[email protected]>
mjcheetham
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into so many troubles while working on v2.48.0-rc2 that I decided to take a bit of time to look carefully at all the changes that were integrated over the holidays (when most people stayed away from their keyboards, and I should have done the same). While kicking the tires of Git for Windows v2.48.0-rc1 I noticed that the Pacman package recorded a different packager than signer. And after I was half-way through debugging this, I realized that I had already fixed this during the embargoed release last year.
And sure enough, when I looked at the commits that I had meant to merge back into
git-for-windows-automation, I found the fix: ff04892Sadly, the commits are in nowhere near the shape they would need to be to get merged: https://github.com/git-for-windows/git-for-windows-automation/compare/embargoed-builds. So I'll need to spend a lot of time on polishing them, but given that I am still not ready to release Git for Windows v2.48.0-rc2, even though _Git v2.48.0 is supposed to be released tomorrow, that project will have to wait a little.
But here is a thing I can do, to at least get the benefit of some of the patches sooner rather than later: I cherry-picked the most obviously-good patches.