Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config for several popular GitLab instances to docs #867

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Add config for several popular GitLab instances to docs #867

merged 3 commits into from
Sep 23, 2022

Conversation

hickford
Copy link
Contributor

Workaround for #677

@hickford hickford changed the title Convenience config for several popular GitLab instances Add config for several popular GitLab instances to docs Sep 17, 2022
@hickford hickford marked this pull request as ready for review September 17, 2022 22:48
dscho
dscho approved these changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great!

ldennington
ldennington approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@ldennington ldennington left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for elevating this for users! ⭐

docs/gitlab.md Outdated Show resolved Hide resolved
@hickford @ldennington
Update docs/gitlab.md
86091b8 
Co-authored-by: Lessley Dennington <[email protected]>
ldennington
ldennington requested changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@ldennington ldennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just came up with one more comment, thank you for bearing with me!

docs/gitlab.md Outdated Show resolved Hide resolved
ldennington
ldennington approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@ldennington ldennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @hickford!

@ldennington ldennington merged commit 4a73bc7 into git-ecosystem:main Sep 23, 2022
@hickford
Copy link
Contributor Author

Brilliant, thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscho dscho dscho approved these changes

@ldennington ldennington ldennington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hickford @dscho @ldennington