install from source: use native feeds for Ubuntu 22.04 #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
reviewed
Aug 15, 2022
ldennington
force-pushed
the
ubuntu-jammy
branch
from
855f12f
to
7e826f4
Compare
ldennington
changed the title
ldennington
changed the title
derrickstolee
approved these changes
Aug 17, 2022
ldennington
force-pushed
the
ubuntu-jammy
branch
6 times, most recently
from
75bcbea
to
0e43350
Compare
The dotnet team recently added support for installing natively from Jammy feeds on Ubuntu 22.04: dotnet/core#7699 This unfortunately created problems with our current install from source script, as it caused conflicts with the packages.microsoft.com feed we use for Debian/Ubuntu. This change modifies the Debian/Ubuntu dotnet install process to install from Jammy feeds for users on Ubuntu 22.04 and greater while continuing to use the packages.microsoft.com feed for Debian and older Ubuntu versions.
Update comments in the install from source script so that: 1. Sentences begin with capital letters. 2. Sentences end with punctuation. 3. Comments are within 80 characters per line.
ldennington
changed the title
ldennington
force-pushed
the
ubuntu-jammy
branch
from
0e43350
to
ba3e2b1
Compare
Merged
ldennington
added a commit
that referenced
this pull request
Nov 3, 2022
Changes: - Check for broken links in documentation (#700) - Support macOS `arm64` installs via Homebrew (#798) - Validate installers before publishing (#813) - Auto-generate maintainer away notification issues (#842) - Install dotnet via Jammy feeds on Ubuntu 22.04 and greater (#839) - Access Azure storage account using service principle credentials (#851) - Update documentation to use reference-style links (#680) - Unify documentation line length (#862) - Add generic username/password UI (#871) - Bitbucket DC OAuth support (#607) - Distribute GCM as a dotnet tool (#886) - Drop `-core` suffix from entry executable #551 - Speed up build graph (#924)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dotnet team recently added support for installing natively from Jammy feeds on
Ubuntu:
dotnet/core#7699
This caused our current installation to fail, as it caused conflicts with
the packages.microsoft.com feed we use in the install from source script
for Debian/Ubuntu.
This change modifies the Debian/Ubuntu dotnet install process to install from
Jammy feeds for users on Ubuntu 22.04 and greater while continuing to use
the packages.microsoft.com feed for Debian and older Ubuntu versions.
Here is a successful run of the validation workflow with these changes: https://github.com/ldennington/git-credential-manager/actions/runs/2884331734
Fixes #841