Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: capture nuget signing cert #1594

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

ldennington
Copy link
Contributor

@ldennington ldennington commented Apr 19, 2024

NuGet requires that signed packages have a matching registered signing certificate. Update release workflow to capture this certificate from the Sign CLI tool and upload it as a release artifact. Note that this means we will need to manually update this certificate to the git-credential-manager organization in nuget.org prior to publishing the .NET tool version for each release.

Tested the end-to-end flow in my fork which resulted in publication of this package to the NuGet QA Gallery.

NuGet requires that signed packages have a matching registered signing
certificate [1]. Update release workflow to capture this certificate from the Sign
CLI tool and upload it as a release artifact.

1: https://learn.microsoft.com/en-us/nuget/create-packages/sign-a-package#register-the-certificate-on-nugetorg
@ldennington ldennington merged commit 87b3a1a into git-ecosystem:main Apr 20, 2024
6 checks passed
@mjcheetham mjcheetham mentioned this pull request Jul 2, 2024
mjcheetham added a commit that referenced this pull request Jul 2, 2024
**Changes:**

- Update MSAL and Avalonia to latest versions (#1640).
- Changes to release workflow to publish NuGet signing certificate
(#1594, #1644, #1647).
- Updates to Managed Identity and Service Principal docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants