azure-repos: fix org name in userinfo #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug in the Azure Repos host provider that prevented the Azure DevOps organisation name from being pulled from the userinfo part of the remote URL. When creating the remote URL from Git input in multiple places we had not been preserving the userinfo part that was subsequently passed to the `CreateOrganizationUri` helper method to extract the org URL. Also add an additional test for PAT mode to cover this use case.
hickford
approved these changes
Jan 26, 2024
vdye
approved these changes
Feb 22, 2024
Yep! When the rename from Visual Studio Team Services to Azure DevOps happened, and the URLs changed from Here's the "Clone" button on an Azure DevOps repo showing the default generated URL with the org name in the userinfo part of the URL.. 
|
Merged
mjcheetham
added a commit
that referenced
this pull request
Apr 16, 2024
**Changes:** - Fixes to install from source script (#1469) - Use Avalonia generated view code (#14790 - Various GitHub Actions updates (#1473, #1483, #1487, #1486, #1488, #1528, #1547) - Fix bug in Azure Repos URL handling (#1522) - Add Azure Managed Identity and SP docs (#1548) - Fix error messages when using GCM outside of repo (#1561, #1583) - Remove ESRP (#1571) - Update to .NET 8 for Mac and Linux (#1579, #1580) - Fix Alpine install from source script (#1582)
Redemtion1
reviewed
Jun 7, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in the Azure Repos host provider that prevented the Azure DevOps organisation name from being pulled from the userinfo part of the remote URL.
When creating the remote URL from Git input in multiple places we had not been preserving the userinfo part that was subsequently passed to the
CreateOrganizationUrihelper method to extract the org URL.Also add an additional test for PAT mode to cover this use case.
Fixes #1520