Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioning: transition from nerdbank to version file #1231

Merged
merged 4 commits into from
May 2, 2023

Commits on Apr 29, 2023

  1. version: replace nerdbank with version file

    Remove Nerdbank.GitVersioning dependency from project in favor of a new
    VERSION file, which will be updated ahead of each release. Versioning in
    this file will begin with the version we plan to use for the next release:
    2.1.0.0.
    
    This change involves the addition of a new custom MSBuild task, which
    reads in the contents of the VERSION file, converts it to a Version
    object, and then sets the various version-related MSBuild properties with
    the correct value (some with the `Revision` component appended, others
    without).
    
    Note that there is a bug in MSAL [1] that causes build failures for
    projects without dependencies with this change. We add Newtonsoft.Json as
    a global dependency in Directory.Build.props to work around this problem
    until the fix is released.
    
    [1]: AzureAD/microsoft-authentication-library-for-dotnet#4108
    ldennington committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    6ab469f View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. version: update release workflow versioning

    Update release workflow to use VERSION file for versioning, rather than
    Nerdbank.GitVersioning.
    ldennington committed May 1, 2023
    Configuration menu
    Copy the full SHA
    59b47c5 View commit details
    Browse the repository at this point in the history
  2. version: remove nerdbank tasks

    Remove Nerdbank.GitVersioning tasks (which have been superceded by the use
    of the new VERSION file) from the release workflow.
    ldennington committed May 1, 2023
    Configuration menu
    Copy the full SHA
    ba07ba9 View commit details
    Browse the repository at this point in the history
  3. workflows: update checkout actions

    Remove fetch-depth from checkout actions, since that was required by
    Nerdbank.GitVersioning. Also take this opportunity to use consistent version
    and naming for checkout actions.
    ldennington committed May 1, 2023
    Configuration menu
    Copy the full SHA
    20f918b View commit details
    Browse the repository at this point in the history