test(cron): pin profile-adapter routing seams (regression guard) - #16
Merged
Merged
Conversation
…026-08-19) The upstream catchup rebase (merge PR #14, 2026-08-19) silently dropped the fork's profile-adapter routing fix (PR #13) — profile cron jobs delivered through the root bot to the root DM for a day and every per-profile channel went silent. No test pinned the three seams, so the drop was invisible to CI. Add test_multiplex_ticker_passes_profile_specific_adapters: - asserts start() and _start_multiplex() carry profile_adapters - asserts _start_multiplex selects per-profile adapter dicts - asserts the root fallback for adapter-less profiles - behaviorally verifies each profile tick receives ITS OWN adapters Verified: fails on fa95c40 (pre-fix), passes on 57bfb25 (fixed).
૮ >ﻌ< ა ci reviewran on 609b147 — ci: re-trigger checks
|
Owner
Author
|
Clearing a stuck merge state from a transient 502; reopening to re-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression guard for the 2026-08-19 profile-delivery incident. The upstream catchup rebase (merge PR #14) silently dropped the fork's profile-adapter routing fix (PR #13, commit 27d7e15); every profile cron job delivered through the ROOT bot to the root DM for a day and per-profile channels went silent. No test pinned the seam, so CI stayed green while delivery was broken.
New test: test_multiplex_ticker_passes_profile_specific_adapters
Verified both directions: FAILS on fa95c40 (pre-fix code, AssertionError at the seam), PASSES on 57bfb25 (fixed). Full tests/cron: 802 passed, 5 skipped.