Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please implement more client/v3/search filters: senders, not_senders #596

Open
grinapo opened this issue Oct 21, 2024 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@grinapo
Copy link

grinapo commented Oct 21, 2024

POST /_matrix/client/v3/search is used by Rust SDK, when doing room.messages(options) with MessagesOption and RoomEventFilter with senders field (or at least I think that's the API call).

I would use the call for the Robot to collect all past messages for deletion of a user to be very kickbanned. (The method would be searching backwards in loop until either reaching the top or the bot getting bored scrolling back without success.)

This would need working senders (and possibly its inverse: not_senders) in the filter.

(Other filters may not be hard to code the same time, but my focus is on that one now.)

(Sidenote: it seems conduwuit does not even log unsupported (and thus dropped) filter attributes. Is this intentional?)

@girlbossceo girlbossceo added the enhancement New feature or request label Oct 21, 2024
@girlbossceo
Copy link
Owner

The lack of filters is an inherited thing from Conduit, it's not intentional.

@grinapo
Copy link
Author

grinapo commented Oct 21, 2024

I think the same stands for GET /_matrix/client/v3/rooms/{roomId}/messages API call, using the same filtering framework. Or maybe the SDK uses this call instead, I don't know.

@jevolk jevolk self-assigned this Oct 21, 2024
jevolk added a commit to jevolk/conduwuit that referenced this issue Oct 26, 2024
jevolk added a commit to jevolk/conduwuit that referenced this issue Oct 27, 2024
jevolk added a commit to jevolk/conduwuit that referenced this issue Oct 27, 2024
jevolk added a commit to jevolk/conduwuit that referenced this issue Oct 27, 2024
jevolk added a commit to jevolk/conduwuit that referenced this issue Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants