Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Dicom Web Assetstore Plugin to Girder 5 #1800

Merged
merged 13 commits into from
Feb 19, 2025
Merged

Convert Dicom Web Assetstore Plugin to Girder 5 #1800

merged 13 commits into from
Feb 19, 2025

Conversation

naglepuff
Copy link
Collaborator

No description provided.

@naglepuff naglepuff force-pushed the convert-dicomweb-plugin-to-girder5 branch from 047842d to 8558b7e Compare January 31, 2025 23:11
@naglepuff naglepuff marked this pull request as ready for review February 14, 2025 22:22
@naglepuff
Copy link
Collaborator Author

This may need to change (just a small change) depending on the outcome of girder/girder#3617

@willdunklin
Copy link
Contributor

If the above change (girder/girder#3617) gets added, here's how I updated girder_assetstore to work with the assetstoreImportViewMap changes:
https://github.com/DigitalSlideArchive/girder_assetstore/blob/girder-5/girder_assetstore/web_client/views/ImportView.js#L107

@naglepuff
Copy link
Collaborator Author

Since girder/girder#3617 has been closed, this will not need to change before merge.

@naglepuff naglepuff requested a review from manthey February 18, 2025 15:28
manthey
manthey approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@manthey manthey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me.

@naglepuff naglepuff merged commit 5f98f17 into girder-5 Feb 19, 2025
15 checks passed
@naglepuff naglepuff deleted the convert-dicomweb-plugin-to-girder5 branch February 19, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manthey manthey manthey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naglepuff @willdunklin @manthey