Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HandleOptionGracefullyAnalyzer for ETag and Last-Modified at Preconditional.fs #613

Merged
merged 1 commit into from
Sep 5, 2024
Merged

HandleOptionGracefullyAnalyzer for ETag and Last-Modified at Preconditional.fs #613

merged 1 commit into from
Sep 5, 2024

Conversation

64J0
Copy link
Member

@64J0 64J0 commented Sep 5, 2024 •
edited
Loading

Description

With this PR, I'm solving this scan result (ionide.Analyzers) for the Preconditional.fs file, rule id IONIDE-006:

Replace unsafe option unwrapping with graceful handling of each case.

  • Documentation link.

Note

This will not change any project behavior.

Solves:

@64J0 64J0 marked this pull request as ready for review September 5, 2024 00:58
@64J0 64J0 self-assigned this Sep 5, 2024
@64J0
use Option.iter for eTag and lastModified values at Precondition.fs, …
e4ca08f 
…due to ionide-analyzers HandleOptionGracefullyAnalyzer
@64J0 64J0 force-pushed the fix-ionide-handle-option-gracefully-preconditional branch from 215be44 to e4ca08f Compare September 5, 2024 22:30
@64J0 64J0 merged commit 1edaf3f into master Sep 5, 2024
10 checks passed
@64J0 64J0 deleted the fix-ionide-handle-option-gracefully-preconditional branch September 5, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees

@64J0 64J0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@64J0 @nojaf