Add version check to chromedriver and browser #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added bug fixes for selenium 4 updates in Python. Selenium has a chrome driver package manager now so no need for auto-checking chrome driver. Chrome >115 only works with the Chrome for Testing dashboard. |
ginglis13
reviewed
Sep 15, 2023
scraper.py
Outdated
Comment on lines
85
to
88
| url= GOOGLE_URL + '?q=' + companyName | ||
| result = requests.get(url) | ||
| # fancy regex courtesy of pbui | ||
| urls = re.findall('/url\?q=([^&]*)', result.text) | ||
| urls= re.findall('/url\?q=([^&]*)', result.text) |
ginglis13
reviewed
Sep 15, 2023
scraper.py
Outdated
| # enter email and password. uses getpass to hide password (i.e. not using plaintext) | ||
| your_email=raw_input("Please enter your email for magicformulainvesting.com: ") | ||
| # Replace with raw_input() with input() for python 3 | ||
| your_email= input("Please enter your email for magicformulainvesting.com: ") |
scraper.py
Outdated
| date=datetime.datetime.today().strftime('%Y-%m-%d') # current date | ||
| wks.append_row([date], table_range='A1') # append the date, starts in first column | ||
| wks = gc.open_by_url("YOUR URL HERE" |
|
Thanks yo just a couple nits/qs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would prevent the code from downloading the chromedriver that is a version ahead of your chome browser if for some reason the automatic install has not yet happened (for example, my chrome browser is not yet at version 111, but chromedriver already released a 111 version).