fix: Set default value for form fields#4047
Merged
appleboy merged 1 commit intogin-gonic:masterfrom Sep 6, 2024
Conversation
- Use specified default value in struct tags when binding a request input to struct for validation, even if sent empty, not only when not sent at all. - Add string field to `TestMappingDefault` test case. - Add test case for not sent form field to default to the value specified via code. - Add test case for form field sent empty to default to the value specified via code. Fixes: How to apply default value if empty value provided by client during model binding? gin-gonic#4042, #13042df, #a41721a
ahmadSaeedGoda
force-pushed
the
fix/apply-default-value-if-empty-value-provided-by-client-during-model-binding
branch
from
b31017d to
497351c
Compare
Contributor
Author
|
@thinkerou @appleboy Kindly review this tiny portion, highly appreciated! 🆒 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4047 +/- ##
==========================================
- Coverage 99.21% 98.85% -0.36%
==========================================
Files 42 44 +2
Lines 3182 2801 -381
==========================================
- Hits 3157 2769 -388
- Misses 17 19 +2
- Partials 8 13 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
appleboy
approved these changes
Sep 6, 2024
appleboy
added
the
type/bug
1911860538
pushed a commit
to 1911860538/gin
that referenced
this pull request
Feb 26, 2025
- Use specified default value in struct tags when binding a request input to struct for validation, even if sent empty, not only when not sent at all. - Add string field to `TestMappingDefault` test case. - Add test case for not sent form field to default to the value specified via code. - Add test case for form field sent empty to default to the value specified via code. Fixes: How to apply default value if empty value provided by client during model binding? gin-gonic#4042, #13042df, #a41721a
This was referenced Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: How to apply default value if empty value provided by client during model binding? #4042, #13042df, #a41721a
master