add an option to have the default value as a list with commas as seperator#2744
Closed
n3aka wants to merge 2 commits intogin-gonic:masterfrom
Closed
add an option to have the default value as a list with commas as seperator#2744n3aka wants to merge 2 commits intogin-gonic:masterfrom
n3aka wants to merge 2 commits intogin-gonic:masterfrom
Conversation
added 2 commits
June 1, 2021 08:57
typo other one
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2744 +/- ##
=======================================
Coverage 98.69% 98.70%
=======================================
Files 41 41
Lines 2074 2079 +5
=======================================
+ Hits 2047 2052 +5
Misses 15 15
Partials 12 12 ☔ View full report in Codecov by Sentry. |
daheige
approved these changes
Jun 5, 2021
daheige
approved these changes
Jun 5, 2021
Contributor
|
@appleboy Hi, can we get this PR merged since it was already approved? (I can make a copy of this PR with conflicts fixed if that's the only blocker to getting this released publicly) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open your pull request against
masterYour pull request should have no more than two commits, if not you should squash them.
It should pass all tests in the available continuous integration systems such as TravisCI.
You should add/modify tests to cover your proposed code changes.
If your pull request contains a new feature, please document it on the README.
The idea was like mentioned on the title to be able to specify multiple default values that will come back as a slice