Skip to content

add an option to have the default value as a list with commas as seperator#2744

Closed
n3aka wants to merge 2 commits intogin-gonic:masterfrom
n3aka:master
Closed

add an option to have the default value as a list with commas as seperator#2744
n3aka wants to merge 2 commits intogin-gonic:masterfrom
n3aka:master

Conversation

@n3aka
Copy link
Copy Markdown

@n3aka n3aka commented Jun 1, 2021

  • Open your pull request against master

  • Your pull request should have no more than two commits, if not you should squash them.

  • It should pass all tests in the available continuous integration systems such as TravisCI.

  • You should add/modify tests to cover your proposed code changes.

  • If your pull request contains a new feature, please document it on the README.

The idea was like mentioned on the title to be able to specify multiple default values that will come back as a slice

oliver hofmann added 2 commits June 1, 2021 08:57
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (6703dea) to head (2e7b385).
Report is 337 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2744   +/-   ##
=======================================
  Coverage   98.69%   98.70%           
=======================================
  Files          41       41           
  Lines        2074     2079    +5     
=======================================
+ Hits         2047     2052    +5     
  Misses         15       15           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takanuva15
Copy link
Copy Markdown
Contributor

@appleboy Hi, can we get this PR merged since it was already approved? (I can make a copy of this PR with conflicts fixed if that's the only blocker to getting this released publicly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants