Setting trusted platform using an enum-like #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItalyPaleAle
force-pushed
the
codespaces-5302
branch
from
66dbc0d to
b2e0a85
Compare
Codecov Report
@@ Coverage Diff @@
## master #2739 +/- ##
=======================================
Coverage 98.69% 98.70%
=======================================
Files 41 41
Lines 2074 2078 +4
=======================================
+ Hits 2047 2051 +4
Misses 15 15
Partials 12 12
Continue to review full report at Codecov.
|
|
@thinkerou this was the modified PR you requested. Let me know if it's good or you want me to make further changes |
|
waiting @appleboy review, thanks! |
appleboy
approved these changes
Jun 24, 2021
thinkerou
added a commit
that referenced
this pull request
Jun 24, 2021
…2751) * Update tree.go (#2659) delete more "()" * updated comments for Get function for params (#2756) * ci: add github action workflows (#2596) * ci: add github action workflows * test: fixed the TestUnixSocket test on windows (#20) * ci: add github action workflows (#18) * Remove .travis.yml * ci: replace GITTER_ROOM_ID and upload coverage every time you go test * ci: update coverage using codecov/codecov-action@v1 * Merge branch 'master' into github-actions * repo: replace travis ci to github actions * ci: add go version 1.16 * fix: go install requires a specific version * chore(ci): remove go 1.12 support * chore(ci): remove os windows-latest Co-authored-by: thinkerou <[email protected]> Co-authored-by: Bo-Yi Wu <[email protected]> * Setting trusted platform using an enum-like (#2739) * gin.Context with fallback value from c.Request.Context() * add test case Co-authored-by: youzeliang <[email protected]> Co-authored-by: Ashwani <[email protected]> Co-authored-by: Jeff <[email protected]> Co-authored-by: thinkerou <[email protected]> Co-authored-by: Bo-Yi Wu <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]>
thinkerou
pushed a commit
that referenced
this pull request
Nov 21, 2021
Bisstocuz
pushed a commit
to Bisstocuz/gin
that referenced
this pull request
Nov 22, 2021
(cherry picked from commit dd8a27c)
Bisstocuz
pushed a commit
to Bisstocuz/gin
that referenced
this pull request
Nov 22, 2021
(cherry picked from commit dd8a27c)
Bisstocuz
pushed a commit
to Bisstocuz/gin
that referenced
this pull request
Nov 22, 2021
(cherry picked from commit dd8a27c)
Bisstocuz
pushed a commit
to Bisstocuz/gin
that referenced
this pull request
Nov 22, 2021
(cherry picked from commit dd8a27c)
thinkerou
pushed a commit
that referenced
this pull request
Nov 23, 2021
Bisstocuz
pushed a commit
to Bisstocuz/gin
that referenced
this pull request
Nov 23, 2021
(cherry picked from commit dd8a27c)
thinkerou
pushed a commit
that referenced
this pull request
Nov 24, 2021
thinkerou
pushed a commit
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated #2723 using an enum-like.
This also marks
AppEngineas deprecated (note that we can't detect people usingAppEngine: falsebecause that's also the zero value, so we can only show an error message to people who setAppEngine: true).This removes the
Cloudflareproperty set in #2723, which was never released anyways.