Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make from_bytes integer constructors const #712

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Make from_bytes integer constructors const #712

merged 1 commit into from
Aug 1, 2024

Conversation

ChrisDenton
Copy link
Contributor

These functions are all trivially const. Having a const way to construct these types allows for a safe way of constructing them in a static or const item.

philipc
philipc approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit b138dab into gimli-rs:master Aug 1, 2024
10 checks passed
@ChrisDenton ChrisDenton deleted the const branch August 1, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisDenton @philipc