read/coff: SymbolKind::Common detection was too broad #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Common symbols should be IMAGE_SYM_CLASS_EXTERNAL. We were also matching on IMAGE_SYM_CLASS_SECTION, which can occur for section symbols in import libraries where the section is defined in another archive member.
philipc
force-pushed
the
issue-591-section-common
branch
from
add2ce5 to
e8662af
Compare
philipc
force-pushed
the
issue-591-section-common
branch
from
1b2ba64 to
e8662af
Compare
mcbegamerxx954
pushed a commit
to mcbegamerxx954/object
that referenced
this pull request
Jun 15, 2024
Common symbols should be IMAGE_SYM_CLASS_EXTERNAL. We were also matching on IMAGE_SYM_CLASS_SECTION, which can occur for section symbols in import libraries where the section is defined in another archive member.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common symbols should be IMAGE_SYM_CLASS_EXTERNAL.
We were also matching on IMAGE_SYM_CLASS_SECTION, which can occur for section symbols in import libraries where the section is defined in another archive member.