xcoff improvements #527
Merged
xcoff improvements #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also handle XCOFF flags in objcopy.
This is more reliable than looking at section kinds. Also change the write logic to give preference to the symbol kind rather than the section kind.
write::Symbol::value is a section offset, but xcoff::Symbol*::value is absolute.
|
Hi @philipc , sorry for not notice this PR in time. This PR LGTM and much appreciated for promoting XCOFF support to stable feature. |
|
Great, thanks for reviewing. I'll do a release soon if there's no outstanding XCOFF issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Please review @EsmeYi @bzEq