write/xcoff: add support. #482

EsmeYi · 2022-11-07T03:30:43Z

No description provided.

philipc

There's a few things that need fixing. I think there will also be more that needs fixing once you are actually using this. Have you used this to write any object files other than the one written by the test added in this PR?

src/write/xcoff.rs

EsmeYi · 2022-11-09T08:41:59Z

Convert this PR to draft for now, since this PR will rebase on #484.

src/write/xcoff.rs

philipc

Is this still a draft?

src/write/xcoff.rs

Cargo.toml

EsmeYi · 2023-02-02T04:40:56Z

@philipc Thanks a lot for your comment and I apologize for my late reply as I was on vacation last month. I just post a PR rust-lang/rust#107583 to support metadata on AIX, which is related to this PR, specifically the C_INFO symbol here.

src/write/xcoff.rs

src/common.rs

This reverts commit 1fced0e.

tests/round_trip/mod.rs

2. implement a new function symbol_address_by_name().

philipc · 2023-02-23T08:23:08Z

I think this is good to merge once CI is passing, so please continue working on fixes for that.

EsmeYi · 2023-02-23T09:39:35Z

Thank you for your review. Checks are clean now.

crates/examples/testfiles/xcoff/base.o.objdump

bzEq · 2023-03-14T10:19:00Z

Hi @philipc , what abstraction level do we expect from object crate? Is it user's responsibility to make the final object file legal?
For example, in XCOFF, there is a .info section, AIX toolchain expects the data inside this section is a sequence of string whose first 4 bytes is the length of this string. When user appends data to this section, should user be aware of this knowledge?

philipc · 2023-03-14T11:15:14Z

The object crate will never be able to ensure that the final object is 100% legal. We rely on the user to have knowledge about the file formats and what they require. For the .info section specifically, the object crate will never validate the data that the user appends to the section. We could add a helper function that appends data in the correct format, but we wouldn't prevent the user from appending invalid data using other functions.

src/write/xcoff.rs

philipc

Thanks! I'll merge this soon. Before doing a release I will also do a bit more validation myself, and complete some other unrelated work.

bzEq · 2023-03-23T07:18:47Z

Thanks @philipc , I'll also validate this PR via bootstrapping rustc on AIX. I'll get it done as soon as possible.

bzEq · 2023-03-23T07:47:15Z

src/write/xcoff.rs

+                        }
+                    }
+                } else {
+                    return Err(Error(format!(


There is situation we have a symbol with kind SymbolSection::Undefined, we will set n_scnum to N_UNDEF in line 378. This situation should be valid in XCOFF's view.

bzEq

I've verify the PR via bootstrapping rustc 1.70.0-dev on AIX. Current implementation looks good to me.

philipc · 2023-04-12T01:06:33Z

src/read/traits.rs

@@ -119,6 +119,21 @@ pub trait Object<'data: 'file, 'file>: read::private::Sealed {
    /// Returns an error if the index is invalid.
    fn symbol_by_index(&'file self, index: SymbolIndex) -> Result<Self::Symbol>;

+    /// Get the address of symbol named `symbol_name`, if such a symbol exists.
+    fn symbol_address_by_name(&'file self, symbol_name: &str) -> Result<u64> {


I overlooked the addition of this when reviewing. It didn't really belong in this PR, and I'm not confident that this is an API we want to support because it seems too specialized to me, so I'm going to remove it again.

Yes, it seems quite specific, however the function is going to be called in https://github.com/rust-lang/rust/pull/107583/files#diff-6bbf6edd930f26d3b180eb5c250b0e48d8f3c5eb474e3274909ef6ae6f0d1e61R109

Since rust-lang/rust#107583 is not landed yet, we can still look for a solution without these new APIs. And as I asked in #482 (comment) and @philipc answered in #482 (comment), we can still use existing APIs and our knowledge of XCOFF to get the work done.

Ok, I have no objection to removing this function.

philipc requested changes Nov 8, 2022

View reviewed changes

EsmeYi marked this pull request as draft November 9, 2022 08:42

write/xcoff: add support.

6a75fda

EsmeYi force-pushed the xcoff_write branch from 2661489 to 6a75fda Compare December 1, 2022 08:29

Address comments and add support for the auxiliary symbol.

65b2fe9

philipc reviewed Dec 27, 2022

View reviewed changes

src/write/xcoff.rs Outdated Show resolved Hide resolved

src/write/xcoff.rs Outdated Show resolved Hide resolved

philipc requested changes Dec 27, 2022

View reviewed changes

src/write/xcoff.rs Outdated Show resolved Hide resolved

src/write/xcoff.rs Outdated Show resolved Hide resolved

Address comments.

f23311c

EsmeYi marked this pull request as ready for review January 5, 2023 05:01

philipc reviewed Jan 5, 2023

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

philipc requested changes Feb 3, 2023

View reviewed changes

src/write/xcoff.rs Outdated Show resolved Hide resolved

src/write/xcoff.rs Outdated Show resolved Hide resolved

src/write/xcoff.rs Outdated Show resolved Hide resolved

Address comments (adjust the storage_class).

c2c4a0d

philipc reviewed Feb 8, 2023

View reviewed changes

src/common.rs Outdated Show resolved Hide resolved

EsmeYi added 3 commits February 8, 2023 16:02

Modify SymbolFlags::Xcoff.

1fced0e

Revert "Modify SymbolFlags::Xcoff."

355d7c8

This reverts commit 1fced0e.

Modify SymbolFlags::Xcoff

606117b

philipc reviewed Feb 21, 2023

View reviewed changes

tests/round_trip/mod.rs Show resolved Hide resolved

EsmeYi added 3 commits February 22, 2023 14:31

1. add cfg feature for test.

b608c46

2. implement a new function symbol_address_by_name().

Merge branch 'master' into xcoff_write

a217b49

Rebase.

36ddbe0

Update the test result.

4228f1f

philipc requested changes Feb 23, 2023

View reviewed changes

crates/examples/testfiles/xcoff/base.o.objdump Outdated Show resolved Hide resolved

bzEq reviewed Mar 20, 2023

View reviewed changes

src/write/xcoff.rs Show resolved Hide resolved

src/write/xcoff.rs Outdated Show resolved Hide resolved

Generate auxiliary entry according to the type of storage_class.

734e77d

fmt.

b37ffb3

philipc approved these changes Mar 23, 2023

View reviewed changes

bzEq reviewed Mar 23, 2023

View reviewed changes

EsmeYi added 2 commits March 23, 2023 16:53

Symbols without section may have auxiliary entry.

452574d

fmt

272622f

bzEq approved these changes Mar 24, 2023

View reviewed changes

philipc merged commit b348128 into gimli-rs:master Mar 27, 2023

philipc reviewed Apr 12, 2023

View reviewed changes

mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024

write/xcoff: add support (gimli-rs#482)

dc30d6c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

write/xcoff: add support. #482

write/xcoff: add support. #482

EsmeYi commented Nov 7, 2022

philipc left a comment

EsmeYi commented Nov 9, 2022

philipc left a comment

EsmeYi commented Feb 2, 2023

philipc commented Feb 23, 2023

EsmeYi commented Feb 23, 2023

bzEq commented Mar 14, 2023

philipc commented Mar 14, 2023

philipc left a comment

bzEq commented Mar 23, 2023

bzEq Mar 23, 2023

bzEq left a comment

philipc Apr 12, 2023

EsmeYi Apr 12, 2023

bzEq Apr 12, 2023 •

edited

Loading

EsmeYi Apr 12, 2023

write/xcoff: add support. #482

write/xcoff: add support. #482

Conversation

EsmeYi commented Nov 7, 2022

philipc left a comment

Choose a reason for hiding this comment

EsmeYi commented Nov 9, 2022

philipc left a comment

Choose a reason for hiding this comment

EsmeYi commented Feb 2, 2023

philipc commented Feb 23, 2023

EsmeYi commented Feb 23, 2023

bzEq commented Mar 14, 2023

philipc commented Mar 14, 2023

philipc left a comment

Choose a reason for hiding this comment

bzEq commented Mar 23, 2023

bzEq Mar 23, 2023

Choose a reason for hiding this comment

bzEq left a comment

Choose a reason for hiding this comment

philipc Apr 12, 2023

Choose a reason for hiding this comment

EsmeYi Apr 12, 2023

Choose a reason for hiding this comment

bzEq Apr 12, 2023 • edited Loading

Choose a reason for hiding this comment

EsmeYi Apr 12, 2023

Choose a reason for hiding this comment

bzEq Apr 12, 2023 •

edited

Loading