-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read/xcoff: initial support. #469
Conversation
As part of this, can you add some simple test files to https://github.com/gimli-rs/object-testfiles, and add tests here for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a high level, this looks great, and thanks for working on it. I'll wait until you've finished before doing a detailed review.
2. Fix some unimplemented issues.
The PR is ready for review now and the format will be clean in next commit. |
Please add a command to build with only the object/.github/workflows/rust.yml Lines 40 to 44 in ef9c666
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay if you want to leave some of this work for future PRs, but please add TODO comments to indicate that support is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small things to fix and then I think this is ready to merge.
You'll also need to add the 32-bit files in gimli-rs/object-testfiles#4 and wait for it to be merged so that this PR can update it. |
Addressed comments. |
Can you include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This patch adds a skeleton for reading XCOFF, which now can parses FileHeader/Sections/Symbols.
Comments are welcome.