-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reading AIX big archive format #462
Conversation
Why did you remove the fixed header definition? |
It's rather an internal structure only used in file structure recognition part ( |
I think it's part of the file format, which is an external structure, and it's documented as such in the link you gave. I prefer if you add it back in please. Also, please don't mark conversation as resolved. It's better if I mark them as resolved myself once I have reviewed. |
Use 'AixFileHeader' to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll do some style changes in a following PR.
Is there a reason you didn't use the member table at the end of the archive that is pointed to by the |
Ah, I did not think of such case when |
The archive format on AIX is called 'big archive' (see definition at https://www.ibm.com/docs/en/aix/7.3?topic=formats-ar-file-format-big), which is quite different from BSD and GNU variants.
This PR will add support for reading it, as part of the efforts porting Rust toolchain onto AIX. (Writing facility was done by wrapping LLVM upstream code in rust-lang/ar_archive_writer#2)
Also thanks to contribution from @jsji.