Quickfix: Ignore errors when loading name subsection. (#403) #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of `wasmparser` currently in use does not support extended name sections [1] and will return an error when such an unknown subsection is encountered. This commit is a quick work-around until `wasmparser` is updated to the most recent version - which is a rather big undertaking unfortunately. One downside of this work-around is that ill-formed name subsections (e.g. for function names) are silently ignored. [1] (https://github.com/WebAssembly/extended-name-section/blob/main/proposals/extended-name-section/Overview.md)
philipc
reviewed
Dec 14, 2021
mcbegamerxx954
pushed a commit
to mcbegamerxx954/object
that referenced
this pull request
Jun 15, 2024
The version of `wasmparser` currently in use does not support extended name sections and will return an error when such an unknown subsection is encountered. This commit is a quick work-around until `wasmparser` is updated to the most recent version - which is a rather big undertaking unfortunately. One downside of this work-around is that ill-formed name subsections (e.g. for function names) are silently ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a work-around for (#403).
The version of
wasmparsercurrently in use does not support extended name sections will return an error when such an unknown subsection is encountered.This commit is a quick work-around until
wasmparseris updated to the most recent version. This is a rather big undertaking unfortunately; it requires major changes inwasm.rssince the API ofwasmparserhas changed quite a bit.If I find the time, I will attempt that and create another PR.
One downside of this work-around is that ill-formed name subsections (e.g. for function names) are silently ignored, but I think this is a manageable tradeoff until
wasmparseris updated. In case you disagree and don't want to merge this, this PR will at least leave some clues on how to fix the issue locally if somebody runs into the same problem I did.