Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write::Object::write_stream #369

Merged
merged 4 commits into from
Aug 30, 2021
Merged

Add write::Object::write_stream #369

merged 4 commits into from
Aug 30, 2021

Conversation

philipc
Copy link
Contributor

@philipc philipc commented Aug 28, 2021

Closes #348
r? @bjorn3

bjorn3 and others added 4 commits August 28, 2021 13:25
This avoids unnecessary reallocations that need to copy the already
written data over.
Copy link
Contributor

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit f9831e6 into gimli-rs:master Aug 30, 2021
@philipc philipc deleted the pr348 branch August 30, 2021 06:11
@bjorn3
Copy link
Contributor

bjorn3 commented Oct 11, 2021

@philipc Could you make a new release soon so that I can use this in rustc?

@philipc
Copy link
Contributor Author

philipc commented Oct 12, 2021

Sure, but I'll wait a little bit more until gimli is ready for a release.

mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
Add `write::Object::write_stream`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants