Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non_exhaustive to all public enums that may be extended #306

Merged
merged 1 commit into from
May 27, 2021

Conversation

philipc
Copy link
Contributor

@philipc philipc commented May 24, 2021

No description provided.

Copy link
Contributor

@mstange mstange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you're interested in my review on this, but I have read through the diff and it all looks reasonable.

@philipc
Copy link
Contributor Author

philipc commented May 27, 2021

Not sure if you're interested in my review on this, but I have read through the diff and it all looks reasonable.

Thanks, I'm always happy to have more reviews!

@philipc philipc merged commit ad3a1ad into gimli-rs:master May 27, 2021
@philipc philipc deleted the nonexhaustive branch May 27, 2021 06:05
mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
Add `non_exhaustive` to all public enums that may be extended
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants