Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for inclusion into libstd #228

Merged
merged 1 commit into from
May 16, 2020
Merged

Conversation

alexcrichton
Copy link
Contributor

@alexcrichton alexcrichton commented May 13, 2020

This applies the same change as gimli-rs/gimli#503 to this crate.

(also see rust-lang/backtrace-rs#328 for some context)

@philipc
Copy link
Contributor

philipc commented May 14, 2020

Looks like this breaks cargo test --all-features.

@philipc
Copy link
Contributor

philipc commented May 14, 2020

It's nice to be able to easily test with all features when testing manually too, so I guess we need to add a new all feature that includes everything except for this.

@alexcrichton alexcrichton force-pushed the dep-of-std branch 2 times, most recently from db7f1f6 to 7c96d2a Compare May 14, 2020 15:29
@alexcrichton
Copy link
Contributor Author

Ah yeah unfortunately I don't know a great way to fix that :(

I've added a feature all though like you mentioned which I think should at least fix CI

@philipc
Copy link
Contributor

philipc commented May 15, 2020

Sorry, one more thing: we also use all-features for docs.rs.

@alexcrichton
Copy link
Contributor Author

Oops indeed, updated!

This applies the same change as gimli-rs/gimli#503 to this crate.
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed another small fix to your branch, hope that's ok.

@philipc philipc merged commit 1dc0960 into gimli-rs:master May 16, 2020
@alexcrichton alexcrichton deleted the dep-of-std branch May 16, 2020 04:43
mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants