Skip to content

Commit

Permalink
Revert to MSRV 1.52 for read-only
Browse files Browse the repository at this point in the history
  • Loading branch information
cuviper committed Jul 8, 2023
1 parent 8f802d1 commit e2d23f5
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ jobs:
with:
submodules: true
- name: Install rust
run: rustup update 1.60.0 && rustup default 1.60.0
run: rustup update 1.52.0 && rustup default 1.52.0
- name: Test
run: cargo test --verbose --no-default-features --features read,std
run: cargo test --verbose --manifest-path crates/msrv-read/Cargo.toml --package object

msrv-all:
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ read_core = []
# Read support for most file formats (including unaligned files).
read = ["read_core", "archive", "coff", "elf", "macho", "pe", "xcoff", "unaligned"]
# Core write support. You will need to enable some file formats too.
write_core = ["crc32fast", "dep:indexmap", "dep:hashbrown"]
write_core = ["crc32fast", "indexmap", "hashbrown"]
# Core write support with libstd features. You will need to enable some file formats too.
write_std = ["write_core", "std", "indexmap?/std", "crc32fast/std"]
write_std = ["write_core", "std", "indexmap/std", "crc32fast/std"]
# Write support for all file formats, including libstd features.
write = ["write_std", "coff", "elf", "macho", "pe", "xcoff"]

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ See [`crates/examples`](crates/examples) for more examples.
Changes to MSRV are considered breaking changes. We are conservative about changing the MSRV,
but sometimes are required to due to dependencies. The MSRV is:

* 1.60.0 for the `read` feature and its dependencies.
* 1.52.0 for the `read` feature and its dependencies.
* 1.64.0 for the `write` feature and its dependencies.

## License
Expand Down
2 changes: 1 addition & 1 deletion clippy.toml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
msrv = "1.60.0"
msrv = "1.52.0"
15 changes: 15 additions & 0 deletions crates/msrv-read/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
[package]
name = "msrv-read"
version = "0.1.0"
edition = "2018"
publish = false

[dependencies.object]
path = "../.."
default-features = false
features = ["read", "std"]

# Do not act as part of the root workspace, so we can
# resolve the dependency tree without hashbrown, which
# requires 1.60 for its dep syntax and 1.64 to build.
[workspace]
1 change: 1 addition & 0 deletions crates/msrv-read/src/main.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fn main() {}

0 comments on commit e2d23f5

Please sign in to comment.