Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PowerPC 64-bit DWARF register mappings #691

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

tmcgilchrist
Copy link
Contributor

Using the definitions from https://openpowerfoundation.org/specifications/64bitelfabi/ with a small test to check the register mappings. I followed the pattern from #574 .

Are there other tests required for these changes? I am testing using my own Rust project that inspects ELF binaries and extracts debug information from them.

The Power32 bindings should be quite similar according to http://refspecs.linux-foundation.org/elf/elfspec_ppc.pdf and https://github.com/torvalds/linux/blob/master/arch/powerpc/perf/perf_regs.c

Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine for the testing. The only better test we could do is check the dwarfdump output on a powerpc binary, but we don't do that sort of thing currently, so as long as you've tested that manually it's fine.

src/arch.rs Outdated Show resolved Hide resolved
src/arch.rs Outdated Show resolved Hide resolved
src/arch.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit c173a41 into gimli-rs:master Jan 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants