Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default Offset to R::Offset #392

Merged
merged 3 commits into from
Feb 22, 2019
Merged

Change default Offset to R::Offset #392

merged 3 commits into from
Feb 22, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Feb 22, 2019

This lets users use the default more often.

@philipc
Change default Offset to R::Offset
b60b3a2 
This lets users use the default more often.
@philipc philipc requested a review from fitzgen February 22, 2019 04:41
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.53% when pulling 04bce75 on philipc:offsets into 2c7fcfe on gimli-rs:master.

fitzgen
fitzgen approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@fitzgen fitzgen merged commit 7c1b9e7 into gimli-rs:master Feb 22, 2019
@philipc philipc deleted the offsets branch February 23, 2019 02:13
@philipc philipc mentioned this pull request Mar 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipc @coveralls @fitzgen