Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename structs in read::line #359

Merged
merged 6 commits into from
Jan 15, 2019
Merged

Rename structs in read::line #359

merged 6 commits into from
Jan 15, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Jan 15, 2019 •
edited
Loading

  • Rename LineNumber* to Line*
    I prefer shorter names in general if there is no significant loss of meaning. These are also the names I have used in write::line (but alternatively we could rename them since they haven't been released).

  • Rename StateMachine to LineRows
    StateMachine is too generic, a more meaningful name is better. For the user, the purpose of this struct is to iterate over line number rows.

  • Rename Opcode to LineInstruction
    An instruction consists of an opcode and some operands. Also Opcode is too generic.

@coveralls
Copy link

coveralls commented Jan 15, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 87.461% when pulling e5bdaef on philipc:line-rename into 00cfd6e on gimli-rs:master.

@philipc
Rename StateMachine to LineRows
3861062
@philipc
Merge StateMachineRegisters into LineRow
1721772 
The separation made things more complicated with no benefit.
@philipc
Delete LineRows::run_to_address()
d469b1f 
This function is flawed because a line row can cover more than just
the address it starts at.
fitzgen
fitzgen approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good renames!

@fitzgen fitzgen merged commit fe5ea91 into gimli-rs:master Jan 15, 2019
@philipc philipc deleted the line-rename branch January 15, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees

@fitzgen fitzgen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipc @coveralls @fitzgen