Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write: implement DW_AT_sibling #344

Merged
merged 2 commits into from
Nov 28, 2018
Merged

write: implement DW_AT_sibling #344

merged 2 commits into from
Nov 28, 2018

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Nov 20, 2018

No description provided.

@philipc philipc requested a review from fitzgen November 20, 2018 09:32
@coveralls
Copy link

coveralls commented Nov 20, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 86.619% when pulling fbce6d7 on philipc:sibling into 82c2a44 on gimli-rs:master.

fitzgen
fitzgen approved these changes Nov 26, 2018
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Thanks for your patience, I was on holiday for most of last week.

src/write/unit.rs Outdated Show resolved Hide resolved
@philipc philipc merged commit bdb7bc9 into gimli-rs:master Nov 28, 2018
@philipc philipc deleted the sibling branch November 28, 2018 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipc @coveralls @fitzgen