added ability to separate the folders for albums and shared albums #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We had a failure in the tests - but it was just a slightly timing sensitive test and re-run passed. Note that the failure in the docker image build phase herer https://github.com/gilesknap/gphotos-sync/actions/runs/9368991609 is benign - its because the PR actions run with your permissions and can't see my docker credentials. So all good. Merging. Thanks! |
|
@rui-nar let me know if you want me to release this or wait for more updates! |
|
You can release it.
I have some other code tweaks but I'll open an "issue" first to explain my
approach since they change some aspects of the way of working. We'll see if
you like it or not. If you do I'll package and do a PR accordingly.
In any case, these were my first PRs and I'm really happy to contribute.
I'm building a more extensive workflow to work with Immich so maybe more
PRs will come, not sure yet.
…On Tue, Jun 4, 2024, 18:26 Giles Knap ***@***.***> wrote:
@rui-nar <https://github.com/rui-nar> let me know if you want me to
release this or wait for more updates!
—
Reply to this email directly, view it on GitHub
<#492 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACP6EX7FBX4QRTWJ4AW2UHDZFXTEXAVCNFSM6AAAAABIYUXD76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXHE2DKMJUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Immich: that sounds interesting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added ability to separate the folders for albums and shared albums using command line arguments. It'll default to the albm folder if no shared album folder path is given.