Change permission before in-place writing or deletion #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent "failed to open" because of readonlys Perm will be fixed by RestoreMetadata.
A Windows problem By the way, deletion never silently failed.
|
|
|
This pull request has been mentioned on Duplicacy Forum. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoring will fail because the file have read-only attribute or read-only permission.
As enabled -overwrite and restore with permission, restoring should overcome this, by set permission to read and write before overwriting.
The same applies to deleting extra files. Grant read and write permission before deleting.
In addition, it's confusing before as failing to delete extra files will be silently ignored. Now it log a warning if here are any errors.