Add APFS snapshot support #415
Conversation
Add's VSS support for macOS using APFS snapshot's
|
|
Restricts VSS under macOS to version 10.13 High Sierra or higher and local volume only
VSS support now determined by: 1) Checking that repository filesystem is APFS rather than by inspecting macOS version 2) Checking that repository resides on local device (as external APFS formatted drives are not supported) rather than crudely by path name
Fixed tabbing
Minor improvement to error handling and small formatting changes
|
I haven't patched my copy yet, but will do so and test. Thanks for doing this, too bad Apple has decided to make the API for APFS snapshots so convoluted to use. The API itself seems simple, minus the criterial for the special entitlement... |
VSS flag usage now indicates support for macOS using APFS in addition to Windows
|
@jt70471 All done, thanks, I'd forgotten about that |
There was a problem hiding this comment.
One more item, I manually tested OK, however, when I updated my cron scripts to include the -vss option for backup, mount and umount commands were not found.
/sbin/ isn't in the PATH by default via cron. I can update that, but might make sense to change your execution of mount and umount to /sbin/mount and /sbin/umount respectively.
Now calls mount and unmount using absolute path
|
@jt70471 agreed, keep the suggestions coming! While I was at it I noticed I inadvertently broke Windows builds but all fixed now |
|
This looks great, the only thing I couldn't test was the check that the filesystem is indeed APFS, because I have already converted all of my macs to APFS! |
|
@gilbertchen I've been running with this patch/feature for a month w/o issues. Any reason you haven't included yet? |
|
Thanks for your contribution and testing! I can't test it myself but if it has been running good for you guys that it should be safe to merge it. |
Add's VSS support for macOS using APFS snapshot
Addresses issue #341