You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: All your events handlers seem to be using tests like ImGui::IsWindowHovered(ImGuiHoveredFlags_AnyWindow) in order to decide whether to forward the event to underlying window. This is generally incorrect and will lead to variety of issues, you should use io.WantMouseCapture for this.
Hey @ocornut,
Thanks a lot for the heads-up! I remember I ended up doing so as a workaround due to a Qt bug, since the rendering surface is an actual Qt Widget within the Qt window, causing some of the native key strokes not being forwarded. I'm not 100% sure, as it's been a while since I last looked into that. I'll double check your suggestion over the weekend and see if anything behavioral-wise has changed with Qt 5.15 / 6.
P.S: Thanks again for all your incredible work on ImGui, I'm so pleased to see the tables branch has been merged to master officially.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
mentioned this pull request
This PR updates ImGui submodule to v1.84.1 and required some changes due to API breaking changes and directory structure.
The CMake scripts and Visual Studio solutions have been updated accordingly.
Fixating on version v1.84.1 instead of v1.84 due to an issue noticed with that release.