Add tvOS support #25
Add tvOS support #25
Conversation
mdyson
commented
Nov 26, 2019
mdyson
commented
- Adds tvOS support to the Podspec, swift package and as a scheme for carthage support
- allows all tests to run as expected using the tvOS sdk
|
@mdyson Sorry, I missed this PR such a long time 🙏 |
Package.swift
Outdated
| @@ -18,5 +18,11 @@ let package = Package( | |||
| .testTarget( | |||
| name: "CrossroadTests", | |||
| dependencies: ["Crossroad"]), | |||
| .target( | |||
| name: "Crossroad-tvOS", | |||
There was a problem hiding this comment.
I think you need not add targets for each platforms on Package.swift.
The required changes are only L8.
There was a problem hiding this comment.
You are correct, I have dropped the other changes in this file.
| import UIKit | ||
| import Crossroad | ||
| import XCTest | ||
| @testable import Crossroad |
There was a problem hiding this comment.
Could you drop @testable?
I want to test whether these classes arepublic .
There was a problem hiding this comment.
No problem, I've changed it to remove @testable. There were a few spots where it is required though since the code is using code marked with internal so I had to leave those test files with it included.
| @@ -8,6 +8,7 @@ before_script: | |||
| - swiftlint --strict | |||
| matrix: | |||
| include: | |||
| - env: NAME=Xcode DESTINATION="platform=iOS Simulator,name=iPhone 8" | |||
| - env: NAME=Xcode DESTINATION="platform=iOS Simulator,name=iPhone 8" SCHEME="Crossroad" | |||
There was a problem hiding this comment.
I prefer to rename to Crossroad-iOS. I'll rename this after merging this.
There was a problem hiding this comment.
Ok, great! I will leave this one alone for you to change.
…m Package.swift
|
Thanks! |
