Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support case insensitive URL pattern #18

Merged
merged 8 commits into from
Aug 5, 2019
Merged

Conversation

giginet
Copy link
Owner

@giginet giginet commented Aug 5, 2019

According to RFC-3986, URL must be case-insensitive.

When opening App from capital-cased URL Scheme, Currently, Crossroad couldn't handle them.

router.register("myapp://users/:id", { return true })
router.openIfPosible(URL(string: "MYAPP://USERS/10"))!

Crossroad 3 can treat URL as case insensitive.
And remove caseInsensitive options from Context.

@giginet giginet self-assigned this Aug 5, 2019
@giginet giginet merged commit 354c3cd into version3 Aug 5, 2019
@giginet giginet deleted the case-insensitive-pattern branch August 5, 2019 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant