Not working with Node.js 14

[giggio]

This is a problem upstream: max-mapper/extract-zip#94

I'm not sure if this is Node.js' problem or extract-zip's problem.

This is the log I get on my machine when I enable debug:

Node.js 14

❯ DEBUG=extract-zip npm i

> [email protected] install /home/giggio/p/node-chromedriver
> node install.js

Current existing ChromeDriver binary is unavailable, proceeding with download and extraction.
Downloading from file:  https://chromedriver.storage.googleapis.com/81.0.4044.69/chromedriver_linux64.zip
Saving to file: /tmp/81.0.4044.69/chromedriver/chromedriver_linux64.zip
Received 1024K...
Received 2062K...
Received 3102K...
Received 4142K...
Received 4840K total.
Extracting zip contents to /tmp/81.0.4044.69/chromedriver.
  extract-zip creating target directory /tmp/81.0.4044.69/chromedriver +0ms
  extract-zip opening /tmp/81.0.4044.69/chromedriver/chromedriver_linux64.zip with opts { dir: '/tmp/81.0.4044.69/chromedriver' } +1ms
  extract-zip zipfile entry chromedriver +4ms
  extract-zip extracting entry { filename: 'chromedriver', isDir: false, isSymlink: false } +1ms
  extract-zip mkdir { dir: '/tmp/81.0.4044.69/chromedriver', recursive: true } +1ms
  extract-zip opening read stream /tmp/81.0.4044.69/chromedriver/chromedriver +0ms
audited 98 packages in 1.702s

3 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

And this is the log on Node 13:

Node.js 13

❯ DEBUG=extract-zip npm i

> [email protected] install /home/giggio/p/node-chromedriver
> node install.js

Current existing ChromeDriver binary is unavailable, proceeding with download and extraction.
Downloading from file:  https://chromedriver.storage.googleapis.com/81.0.4044.69/chromedriver_linux64.zip
Saving to file: /tmp/81.0.4044.69/chromedriver/chromedriver_linux64.zip
Received 1040K...
Received 2080K...
Received 3120K...
Received 4160K...
Received 4840K total.
Extracting zip contents to /tmp/81.0.4044.69/chromedriver.
  extract-zip creating target directory /tmp/81.0.4044.69/chromedriver +0ms
  extract-zip opening /tmp/81.0.4044.69/chromedriver/chromedriver_linux64.zip with opts { dir: '/tmp/81.0.4044.69/chromedriver' } +2ms
  extract-zip zipfile entry chromedriver +3ms
  extract-zip extracting entry { filename: 'chromedriver', isDir: false, isSymlink: false } +1ms
  extract-zip mkdir { dir: '/tmp/81.0.4044.69/chromedriver', recursive: true } +1ms
  extract-zip opening read stream /tmp/81.0.4044.69/chromedriver/chromedriver +0ms
  extract-zip finished processing chromedriver +218ms
  extract-zip zip extraction complete +1ms
Copying to target path /home/giggio/p/node-chromedriver/lib/chromedriver
Fixing file permissions.
Done. ChromeDriver binary available at /home/giggio/p/node-chromedriver/lib/chromedriver/chromedriver
audited 98 packages in 1.458s

3 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

The difference is:

  extract-zip finished processing chromedriver +218ms
  extract-zip zip extraction complete +1ms

I also noticed that the file is actually extracted, but the script stops, I guess Node.js crashes.

This are the build logs:
https://dev.azure.com/giggio/node-chromedriver/_build/results?buildId=297&view=logs&j=edbbe288-f062-5a83-ca13-a390764a1b06&t=a97f51c5-49b6-5323-b0ad-80e976d7c9ec

I'm willing to give it some time so it can fix itself (Node or Extract-zip), but if anyone is willing to send a PR to patch it until then, I'll look into it.

[benjamingr]

Looks like this is already fixed on node master

[giggio]

Node.js 14.1.0 fixed the issue. The build just finished with it, and it worked fine.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.